[browser][non-icu] HybridGlobalization faster encoding for change case.
#85516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsImplements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989. Speeds up the decoding process:
An attempt of encoding implementation using
|
This was referenced Apr 28, 2023
pavelsavara
approved these changes
May 2, 2023
This was referenced May 2, 2023
ilonatommy
added a commit
to ilonatommy/runtime
that referenced
this pull request
May 23, 2023
ilonatommy
added a commit
that referenced
this pull request
May 24, 2023
* Normalization. * Missing measurement. * Trying to fix trimming error. * Applied @pavelsavara's idea. * Code review improvement. * Feedback: standardize the exceptions. * Revert changes from #85516 to clean the CI. * feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.
Speeds up the decoding process:
An attempt of encoding implementation using
TextEncoderwas actually slower than existing one, so it did not get into this PR.TextEncoder[ms]Relevant discussions:
invariant change case on C# side: #85510 (comment)
TextEncoder usage implications: #85510 (comment)