Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mono][interp] Attempt to devirtualize call if we have type information about this #85528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2023
Merged

[mono][interp] Attempt to devirtualize call if we have type information about this #85528

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b30fbc
[mono][interp] Preserve klass information when generating MINT_CKNULL
BrzVlad Apr 26, 2023
6a50122
[mono][interp] Add more specific type information for EqualityCompare…
BrzVlad Apr 26, 2023
791268a
[mono][interp] Devirtualize calls if we can find a final implementation
BrzVlad Apr 26, 2023
d8f06db
[mono][interp] Optimize out null check on ldloca
BrzVlad Apr 26, 2023
05018aa
[mono][interp] Constant fold unop conditionals applied to non null va…
BrzVlad Apr 26, 2023
b36bcfa
[mono][interp] Optimize out unused MINT_BOX
BrzVlad Apr 26, 2023
0488a50
[mono] Remove duplicated code between interp and jit
BrzVlad Apr 27, 2023
0a4224a
[mono][metadata] Allow method to be called for abstract classes
BrzVlad Apr 28, 2023
3b7d61d
[mono][interp] Don't populate wrong type information into the stack s…
BrzVlad May 4, 2023
e3cb92f
[mono][interp] Don't devirtualize final methods
BrzVlad May 8, 2023
b3f1676
[mono][interp] Ensure class is initialized before getting aot method
BrzVlad May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[mono][interp] Don't populate wrong type information into the stack s… 
…tate
  • Loading branch information
@BrzVlad
BrzVlad committed May 23, 2023
commit 3b7d61da0a8c22abb5a8c0ab9c4f3a46d6cbb952
10 changes: 9 additions & 1 deletion src/mono/mono/mini/interp/transform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,16 @@ init_bb_stack_state (TransformData *td, InterpBasicBlock *bb)
{
// FIXME If already initialized, then we need to generate mov to the registers in the state.
// Check if already initialized
if (bb->stack_height >= 0)
if (bb->stack_height >= 0) {
// Discard type information if we have type conflicts for stack contents
for (int i = 0; i < bb->stack_height; i++) {
if (bb->stack_state [i].klass != td->stack [i].klass) {
bb->stack_state [i].klass = NULL;
td->stack [i].klass = NULL;
}
}
return;
}

bb->stack_height = GPTRDIFF_TO_INT (td->sp - td->stack);
if (bb->stack_height > 0) {
Expand Down