Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip stp/ldp only for unwind portion of prolog/epilog #85657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2023
Merged

Skip stp/ldp only for unwind portion of prolog/epilog #85657

merged 4 commits into from
May 3, 2023

Conversation

kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented May 2, 2023 •
edited
Loading

This is the last portion remaining in #81278. We will do peephole optimizations of replacing ldr/str with pair instructions ldp/stp in prolog as well. We will skip the portion of the prolog where we are generating code for unwind.

Fixes: #81278

@ghost ghost assigned kunalspathak May 2, 2023
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the last portion remaining in #81278. We will now skip peephole optimizations only if we are generating code in unwind.

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Contributor Author

Diffs are great.

image

cc: @a74nh , @SwapnilGaikwad

@kunalspathak kunalspathak marked this pull request as ready for review May 2, 2023 18:14
@kunalspathak
Copy link
Contributor Author

@dotnet/jit-contrib

@kunalspathak kunalspathak requested a review from BruceForstall May 2, 2023 18:14
@kunalspathak
Copy link
Contributor Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

BruceForstall
BruceForstall approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

This was referenced May 2, 2023
Closed
Closed
@kunalspathak
Copy link
Contributor Author

gcstress is clean - https://dev.azure.com/dnceng-public/public/_build/results?buildId=259668&view=ms.vss-test-web.build-test-results-tab

@kunalspathak
Copy link
Contributor Author

@BruceForstall - I didn't realize that I didn't push a change that renames unwindarm.cpp to unwindarmarch.cpp. Pushed it now.

@kunalspathak kunalspathak merged commit 372b01f into dotnet:main May 3, 2023
@kunalspathak kunalspathak deleted the peep-prolog-epilog branch May 3, 2023 03:28
@EgorBo EgorBo mentioned this pull request May 16, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize Arm64 ldr/str to ldp/stp optimization
2 participants
@kunalspathak @BruceForstall