Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Capacity property and overloaded TrimExcess #85877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 22, 2023
Merged

Add Capacity property and overloaded TrimExcess #85877

merged 17 commits into from
Nov 22, 2023

Conversation

hrrrrustic
Copy link
Contributor

Close #66426

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Collections new-api-needs-documentation labels May 6, 2023
@ghost
Copy link

ghost commented May 6, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 6, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Close #66426

Author: hrrrrustic
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation, community-contribution
Milestone: -

@hrrrrustic
Copy link
Contributor Author

hrrrrustic commented May 7, 2023 •
edited
Loading

Hashset & Dictionary ctor tests are failing due to increasing capacity to the nearest prime number. Is it fine to hardcode prime numbers in testdata?

This was referenced May 7, 2023
Closed
Closed
eiriktsarpalis
eiriktsarpalis reviewed Jun 22, 2023
View reviewed changes
src/libraries/System.Collections/tests/Generic/HashSet/HashSet.Generic.Tests.cs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test checking that capacity expands after a buffer resize?

eiriktsarpalis
eiriktsarpalis requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TrimExcess implementation appears wrong to me for the case where newCapacity == Count.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 22, 2023
@ghost ghost added the no-recent-activity label Jul 6, 2023
@ghost
Copy link

ghost commented Jul 6, 2023

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@hrrrrustic
Copy link
Contributor Author

hrrrrustic commented Jul 15, 2023 •
edited
Loading

Just a comment to remove inactivity label, don't want to open new PR later 😄
I'll fix comments 2-3 weeks later, busy at work for now :(

Btw what's the deadline for shipping in .net8?

@ghost ghost removed needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity labels Jul 15, 2023
@danmoseley
Copy link
Member

@jeffhandley can share the cutoff for work like this.
Btw please set PR to Draft if it will be inactive, or just close and reopen later.

@hrrrrustic hrrrrustic marked this pull request as draft July 16, 2023 14:20
@eiriktsarpalis
Copy link
Member

Btw what's the deadline for shipping in .net8?

A bit less than a month left, but do keep in mind that subsequent reviewing rounds can introduce additional delay. If it doesn't make it for .NET 8 that's OK too, we will be accepting .NET 9 contributions as soon as development for .NET 8 concludes.

@hrrrrustic hrrrrustic marked this pull request as ready for review August 5, 2023 22:36
@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Aug 7, 2023 •
edited
Loading

We're currently in the process of finalizing .NET 8 work, so we're not accepting any new features. I'll update the milestone and we can revisit this PR in a few weeks when .NET 9 feature work commences.

@ghost
Copy link

ghost commented Nov 22, 2023

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Nov 22, 2023
@ghost ghost removed the no-recent-activity label Nov 22, 2023
@eiriktsarpalis eiriktsarpalis self-assigned this Nov 22, 2023
@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review November 22, 2023 10:59
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 22, 2023
@eiriktsarpalis
Copy link
Member

I've rebased the changes and addressed remaining feedback. Should be good to merge now.

@build-analysis build-analysis bot mentioned this pull request Nov 22, 2023
Closed
@eiriktsarpalis eiriktsarpalis merged commit ebf881e into dotnet:main Nov 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add readonly Capacity property to HashSet<T> and Dictionary<K,V> and TrimExcess to HashSet<T>
3 participants
@hrrrrustic @danmoseley @eiriktsarpalis