Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unify parsing part of BigInteger with CoreLib #85978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 29, 2023
Merged

Unify parsing part of BigInteger with CoreLib #85978

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fee2893
Move NumberBuffer to common
huoyaoyuan Sep 19, 2022
587589d
Add common files for parsing and formatting
huoyaoyuan Jun 10, 2021
b00e235
Move TryParseNumber and dependents to common
huoyaoyuan May 9, 2023
80fd5a5
Use Common for BigInteger parsing and fix exponent
huoyaoyuan May 9, 2023
a3d74ca
Adapt hex parsing
huoyaoyuan May 9, 2023
f8f5bb8
Cleanup unused parsing code
huoyaoyuan May 9, 2023
d5c7099
Move FormatProvider.Number to System.Runtime.Numerics
huoyaoyuan May 9, 2023
fe2f087
Cleanup BigNumber.Parse calls
huoyaoyuan May 9, 2023
8387024
Move BigNumber to Number.BigInteger
huoyaoyuan May 9, 2023
bcc70e3
Remove Formatting.Common for PR
huoyaoyuan May 9, 2023
25b8232
Merge branch 'main' into numerics-format-1
huoyaoyuan May 11, 2023
4a65ce6
Merge branch 'main'
huoyaoyuan Nov 28, 2023
f888f46
Update formatting code in CoreLib
huoyaoyuan Nov 28, 2023
3637bfd
Update TryParseBigInteger
huoyaoyuan Nov 28, 2023
4c1f638
BinaryNumberToBigInteger
huoyaoyuan Nov 28, 2023
b59c05f
HexNumberToBigInteger
huoyaoyuan Nov 28, 2023
45d04c7
Cleanup unused parsing code in FormatProvider.Number
huoyaoyuan Nov 28, 2023
b879de2
Revert hex parsing
huoyaoyuan Nov 28, 2023
712e5e1
Adapt binary with new parsing
huoyaoyuan Nov 28, 2023
df37400
Reapply hex fix
huoyaoyuan Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reapply hex fix
  • Loading branch information
@huoyaoyuan
huoyaoyuan committed Nov 28, 2023
commit df3740094868b708db8c0478c6ec4d68ddaa8501
20 changes: 7 additions & 13 deletions src/libraries/System.Runtime.Numerics/src/System/Number.BigInteger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,11 @@ internal static ParsingStatus TryParseBigIntegerHexNumberStyle(ReadOnlySpan<char

Debug.Assert(partialDigitCount == 0 && bitsBufferPos == -1);

if (isNegative)
{
NumericsHelpers.DangerousMakeTwosComplement(bitsBuffer);
}

// BigInteger requires leading zero blocks to be truncated.
bitsBuffer = bitsBuffer.TrimEnd(0u);

Expand All @@ -491,26 +496,15 @@ internal static ParsingStatus TryParseBigIntegerHexNumberStyle(ReadOnlySpan<char
sign = 0;
bits = null;
}
else if (bitsBuffer.Length == 1)
else if (bitsBuffer.Length == 1 && bitsBuffer[0] <= int.MaxValue)
{
sign = (int)bitsBuffer[0];
sign = (int)bitsBuffer[0] * (isNegative ? -1 : 1);
bits = null;

if ((!isNegative && sign < 0) || sign == int.MinValue)
{
bits = new[] { (uint)sign };
sign = isNegative ? -1 : 1;
}
}
else
{
sign = isNegative ? -1 : 1;
bits = bitsBuffer.ToArray();

if (isNegative)
{
NumericsHelpers.DangerousMakeTwosComplement(bits);
}
}

result = new BigInteger(sign, bits);
Expand Down