Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert.Try{From/To}HexString #86556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 31, 2023
Merged

Convert.Try{From/To}HexString #86556

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3a0c31e
Add implementation
hrrrrustic May 18, 2023
cc13dca
Add tests
hrrrrustic May 20, 2023
eecaed0
Update conditions
hrrrrustic May 20, 2023
b8cb6dd
Add goto
hrrrrustic May 20, 2023
772208f
Some fixes
hrrrrustic May 20, 2023
7333ca3
Some fixes
hrrrrustic May 20, 2023
f23df24
Add comments
hrrrrustic May 20, 2023
70c9321
Few more tests
hrrrrustic May 21, 2023
f80a8d3
Update ref file
hrrrrustic May 21, 2023
9fd5c99
twiced -> twice
hrrrrustic May 21, 2023
d063d4f
Fix null test
hrrrrustic May 21, 2023
986c8fa
try fix roundtrip test
hrrrrustic May 21, 2023
c644e59
fix tabs & naming
hrrrrustic May 21, 2023
794eff8
var -> int
hrrrrustic May 21, 2023
8a858be
Merge remote-tracking branch 'origin/main' into issue-78472
hrrrrustic Jul 30, 2023
6e48f51
Update implementation
hrrrrustic Jul 30, 2023
071e5f4
Fix tests
hrrrrustic Jul 30, 2023
80431ab
fix slicing
hrrrrustic Jul 30, 2023
38d018f
More tests
hrrrrustic Jul 30, 2023
948616f
update xml comments
hrrrrustic Jul 30, 2023
af59a7f
Fill values on invalid data result
hrrrrustic Jul 30, 2023
dbfe893
Fix tests?
hrrrrustic Jul 31, 2023
30afc43
Try update loop
hrrrrustic Jul 31, 2023
010c836
Merge remote-tracking branch 'origin/main' into issue-78472
hrrrrustic Sep 19, 2023
f532064
try fix target buffer size error
hrrrrustic Sep 24, 2023
9afd0cb
Remove Vectorized copy-paste
hrrrrustic Sep 24, 2023
e7439d4
fix naming
hrrrrustic Sep 24, 2023
f247ed0
Apply suggestions from code review
adamsitnik Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some fixes
  • Loading branch information
@hrrrrustic
hrrrrustic committed May 20, 2023
commit 7333ca3a4b1bdabca280db77caf1390eb81f6e13
3 changes: 1 addition & 2 deletions src/libraries/System.Private.CoreLib/src/System/Convert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3050,7 +3050,6 @@ public static string ToHexString(ReadOnlySpan<byte> bytes)

public static bool TryToHexString(ReadOnlySpan<byte> source, Span<char> destination, out int charsWritten)
{
charsWritten = 0;
var length = source.Length;

if (length > int.MaxValue / 2)
Expand All @@ -3072,7 +3071,7 @@ public static bool TryToHexString(ReadOnlySpan<byte> source, Span<char> destinat
return true;

FalseResult:
bytesWritten = 0;
charsWritten = 0;
return false;
}
} // class Convert
Expand Down