Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[wasm] Fix failing blazor tests to handle disabled fingerprinting #86970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[wasm] Fix failing blazor tests to handle disabled fingerprinting #86970

wants to merge 1 commit into from

Conversation

radical
Copy link
Member

@radical radical commented May 31, 2023 •
edited
Loading

dotnet/sdk#31829 disabled fingerprinting by default for blazor projects, and that broke the tests.

Fixes #86959 .

@radical radical requested review from lewing, pavelsavara and maraf May 31, 2023 19:19
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2023
@ghost ghost assigned radical May 31, 2023
@radical radical added arch-wasm WebAssembly architecture area-Build-mono test-failure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 31, 2023
@ghost
Copy link

ghost commented May 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86959 .

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono, test-failure
Milestone: -

@radical
Copy link
Member Author

radical commented May 31, 2023

Failures are relevant.

@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 31, 2023
@build-analysis build-analysis bot mentioned this pull request May 31, 2023
Closed
@radical
Copy link
Member Author

radical commented May 31, 2023

Closing this as the change to the test is not enough. The generation of dotnet.native*js filename is broken, which is being fixed in #86048 .

@radical radical closed this May 31, 2023
@radical radical deleted the fix-blazor-tests branch May 31, 2023 23:05
@radical radical restored the fix-blazor-tests branch June 1, 2023 04:53
@build-analysis build-analysis bot mentioned this pull request Jun 1, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@maraf maraf Awaiting requested review from maraf maraf is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] WBT: Blazor tests failing to find dotnet.native*js
2 participants
@radical @lewing