Extend Task.FromResult default task optimization to 16 byte unmanaged types #87541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types For years, async methods / Task.FromResult has cached a `Task<T>` for `default(T)`, however it was only used when the result value was null. Earlier in this release we extended that optimization to also use the default task when the value was 1, 2, 4, or 8 bytes (and not a reference type). This extends that further to also handle types that are 16 bytes, so as to include types like Decimal, Guid, Int128, and DateTimeOffset.
|
Tagging subscribers to this area: @dotnet/area-system-threading-tasks Issue DetailsFor years, async methods / Task.FromResult has cached a [Params(42, 0)]
public int Value { get; set; }
[Benchmark]
public async Task<Int128> ReturnValue()
{
await Task.CompletedTask;
return Value;
}
|
danmoseley
approved these changes
Jun 14, 2023
ef1aaa6 to
0a05f90
Compare
0a05f90 to
d80b4ca
Compare
gfoidl
reviewed
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For years, async methods / Task.FromResult has cached a
Task<T>fordefault(T), however it was only used when the result value was null. Earlier in this release we extended that optimization to also use the default task when the value was 1, 2, 4, or 8 bytes (and not a reference type). This extends that further to also handle types that are 16 bytes, so as to include types like Decimal, Guid, Int128, and DateTimeOffset.