Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure that the various Min and Max APIs are accelerated where possible #87641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Ensure that the various Min and Max APIs are accelerated where possible #87641

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd02675
Updating Math.Max and Math.Min to utilize AVX512 when available
tannergooding Jun 15, 2023
62ce778
Ensure that Single/Double APIs can be directly handled as intrinsic
tannergooding Jun 15, 2023
9814a3d
Ensure that the various Min and Max APIs are accelerated where possible
tannergooding Jun 15, 2023
c4a6fcc
Don't include ILogB for the time being
tannergooding Jun 16, 2023
0e6353c
Ensure FixupScalar is passed all 4 parameters
tannergooding Jun 16, 2023
5f10143
Apply suggestions from code review
tannergooding Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure FixupScalar is passed all 4 parameters
  • Loading branch information
@tannergooding
tannergooding committed Jun 16, 2023
commit 0e6353c8244bbf06bac2a5af300739c5b5a862db
18 changes: 10 additions & 8 deletions src/coreclr/jit/importercalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8202,8 +8202,8 @@ GenTree* Compiler::impMinMaxIntrinsic(CORINFO_METHOD_HANDLE method,
tbl->gtSimdVal.i32[0] = 0x0700;
}

retNode = gtNewSimdHWIntrinsicNode(TYP_SIMD16, retNode, op2Clone, tbl, NI_AVX512F_FixupScalar,
callJitType, 16);
retNode = gtNewSimdHWIntrinsicNode(TYP_SIMD16, retNode, op2Clone, tbl, gtNewIconNode(0),
NI_AVX512F_FixupScalar, callJitType, 16);
}

if (isNumber)
Expand Down Expand Up @@ -8329,10 +8329,11 @@ GenTree* Compiler::impMinMaxIntrinsic(CORINFO_METHOD_HANDLE method,

tbl1 = impCloneExpr(tbl1, &tbl2, CHECK_SPILL_ALL, nullptr DEBUGARG("Cloning tbl for Math.Max/Min"));

op1Clone =
gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, op2Clone, tbl1, NI_AVX512F_FixupScalar, callJitType, 16);
op1Clone = gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, op2Clone, tbl1, gtNewIconNode(0),
NI_AVX512F_FixupScalar, callJitType, 16);

tmp = gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, tmp, tbl2, NI_AVX512F_FixupScalar, callJitType, 16);
tmp = gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, tmp, tbl2, gtNewIconNode(0), NI_AVX512F_FixupScalar,
callJitType, 16);
}
else
{
Expand Down Expand Up @@ -8371,10 +8372,11 @@ GenTree* Compiler::impMinMaxIntrinsic(CORINFO_METHOD_HANDLE method,

tbl1 = impCloneExpr(tbl1, &tbl2, CHECK_SPILL_ALL, nullptr DEBUGARG("Cloning tbl for Math.Max/Min"));

op1Clone =
gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, op2Clone, tbl1, NI_AVX512F_FixupScalar, callJitType, 16);
op1Clone = gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1Clone, op2Clone, tbl1, gtNewIconNode(0),
NI_AVX512F_FixupScalar, callJitType, 16);

tmp = gtNewSimdHWIntrinsicNode(TYP_SIMD16, tmp, op1Clone, tbl2, NI_AVX512F_FixupScalar, callJitType, 16);
tmp = gtNewSimdHWIntrinsicNode(TYP_SIMD16, tmp, op1Clone, tbl2, gtNewIconNode(0), NI_AVX512F_FixupScalar,
callJitType, 16);
}

return gtNewSimdHWIntrinsicNode(callType, tmp, NI_Vector128_ToScalar, callJitType, 16);
Expand Down