Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix outerloop CI error #87789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix outerloop CI error #87789

merged 2 commits into from
Jun 20, 2023

Conversation

davidwrighton
Copy link
Member

Fix issue where type validation checker failed to instantiate signature before performing signature comparison

Fixes #87716

@ghost ghost assigned davidwrighton Jun 19, 2023
@davidwrighton davidwrighton requested a review from trylek June 19, 2023 22:05
trylek
trylek approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks David for fixing this!

@MichalStrehovsky
Copy link
Member

Fixes #87663 (we have two bugs for this).

@davidwrighton davidwrighton merged commit 0c77cbe into dotnet:main Jun 20, 2023
@davidwrighton davidwrighton mentioned this pull request Jun 20, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

Assignees

@davidwrighton davidwrighton

Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R2R known test failure
3 participants
@davidwrighton @MichalStrehovsky @trylek