[mono] Some UnsafeAccessorAttribute support for methods and constructors #88925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
I moved the |
7 tasks
|
Also need to try out the new tests from #88268 |
|
Pushed some fixes to match the behavior expected by the new tests from #88268 |
3b3a7e2 to
b96bcdb
Compare
|
There will be merge conflicts with #88268 the resolution is on https://github.com/lambdageek/runtime/tree/unsafe-accessor-kind-merge-vitek |
src/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs
Show resolved
Hide resolved
src/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jul 14, 2023
…AccessorsTests.cs Co-authored-by: Aaron Robinson <[email protected]>
…AccessorsTests.cs Co-authored-by: Aaron Robinson <[email protected]>
This was referenced Jul 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the simple cases so far that don't require considering custom modifiers.
Contributes to #86040