Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid string allocation and improve performance of JsonProperty.WriteTo #90074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Avoid string allocation and improve performance of JsonProperty.WriteTo #90074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad30f54
Avoid string allocation in WriteTo when possible.
karakasa Aug 5, 2023
41f5c37
Avoid alloc in unescaping & escaping.
karakasa Aug 5, 2023
d4d84b1
Fix bugs on escaped property names
karakasa Aug 6, 2023
c368aa3
Change IndexOf to Contains if possible.
karakasa Aug 6, 2023
c5c5593
Further avoid alloc by inlining GetUnescapedSpan
karakasa Aug 6, 2023
1528bf3
Move writing logic to JsonElement;
karakasa Aug 7, 2023
5690487
Move logic into JsonDocument
karakasa Aug 11, 2023
b6c8606
fix format
karakasa Aug 11, 2023
9644915
fix format 2
karakasa Aug 11, 2023
63da811
improve comment
karakasa Aug 11, 2023
df8e6fa
removed unused stub
karakasa Sep 21, 2023
d2fd37c
added assertion
karakasa Sep 21, 2023
ecca233
removed unnecessary test
karakasa Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,15 @@ private static void ClearAndReturn(ArraySegment<byte> rented)
}
}

internal void WritePropertyName(int index, Utf8JsonWriter writer)
{
CheckNotDisposed();

DbRow row = _parsedData.Get(index - DbRow.Size);
Debug.Assert(row.TokenType == JsonTokenType.PropertyName);
WritePropertyName(row, writer);
}

private void WritePropertyName(in DbRow row, Utf8JsonWriter writer)
{
ArraySegment<byte> rented = default;
Expand Down
7 changes: 7 additions & 0 deletions src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,6 +1316,13 @@ public void WriteTo(Utf8JsonWriter writer)
_parent.WriteElementTo(_idx, writer);
}

internal void WritePropertyNameTo(Utf8JsonWriter writer)
{
CheckValidInstance();

_parent.WritePropertyName(_idx, writer);
}

/// <summary>
/// Get an enumerator to enumerate the values in the JSON array represented by this JsonElement.
/// </summary>
Expand Down
10 changes: 9 additions & 1 deletion src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonProperty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,15 @@ public void WriteTo(Utf8JsonWriter writer)
ThrowHelper.ThrowArgumentNullException(nameof(writer));
}

writer.WritePropertyName(Name);
if (_name is null)
{
Value.WritePropertyNameTo(writer);
}
else
{
writer.WritePropertyName(_name);
}

Value.WriteTo(writer);
}

Expand Down