Remove unsafe code and make scheme parsing faster in Uri #90087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe previous logic had two similar helpers to match strings to schemes ( I merged the two helpers into one while removing the unsafe code and recognizing all known schemes on all platforms.
(not needed for 8.0)
|
|
Nice example when a cleaner and safer code is faster 👍 |
stephentoub
reviewed
Aug 9, 2023
stephentoub
approved these changes
Aug 9, 2023
This was referenced Aug 17, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic had two similar helpers to match strings to schemes (
CheckKnownSchemesandCheckSchemeSyntax).CheckKnownSchemeswas only used on 32-bit targets, andCheckSchemeSyntaxwasn't checking half of the known schemes.I merged the two helpers into one while removing the unsafe code and recognizing all known schemes on all platforms.
I also changed
ParseSchemeCheckImplicitFileto work on a string instead of pointers since the unsafeness wasn't buying us anything. The net result is safer, faster, and fewer LOC.(not needed for 8.0)