Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use corresponding exception message, if null passed #90505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Use corresponding exception message, if null passed #90505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f88ed3f
use corresponding exception message if null passed
OwnageIsMagic Aug 14, 2023
0edc44a
fix
OwnageIsMagic Aug 14, 2023
055da60
review fixes
OwnageIsMagic Oct 17, 2023
63eadaf
fix tests
OwnageIsMagic Oct 17, 2023
70a07d4
do not use default message if null passed for SystemException, Applic…
OwnageIsMagic Dec 6, 2023
53988f1
change COMException default message
OwnageIsMagic Dec 25, 2023
90748bf
Merge branch 'main' into patch-1
jozkee Jan 16, 2024
ab67239
Merge branch 'main' into patch-1
jozkee Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change COMException default message
  • Loading branch information
@OwnageIsMagic
OwnageIsMagic committed Dec 25, 2023
commit 53988f1546de9f9fd7ac260a2d5b075f9f55a0c2
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
<value>Must specify property Set or Get or method call for a COM Object.</value>
</data>
<data name="Arg_COMException" xml:space="preserve">
<value>Error HRESULT E_FAIL has been returned from a call to a COM component.</value>
<value>Unexpected HRESULT has been returned from a call to a COM component.</value>
</data>
<data name="Arg_COMPropSetPut" xml:space="preserve">
<value>Only one of the following binding flags can be set: BindingFlags.SetProperty, BindingFlags.PutDispProperty, BindingFlags.PutRefDispProperty.</value>
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ExternalException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public override string ToString()

string s = $"{GetType()} (0x{HResult:X8})";

if (!string.IsNullOrEmpty(message ?? SR.Arg_ExternalException))
if (!string.IsNullOrEmpty(message))
{
s += ": " + message;
}
Expand Down