Fix SPMI issue in getHelperFtn #90888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #90711 tldr: call [CORINFO_HELPER_ISINSTANCEOFANY] ;; indirect call
call CORINFO_HELPER_ISINSTANCEOFANY ;; direct callOther API calls with potentially similar behavior are listed in #90886
|
jakobbotsch
approved these changes
Aug 21, 2023
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90711
tldr:
getHelperFtnmay now (since #90412) return different result over time for the same helper id (e.g. if the underlying helper is being jitted to its final tier in background). It doesn't cause any issues for JIT currently as that function is called once per method in lower. So theoretically it's possible to see something like this in codegen:Other EE APIs with potentially similar behavior are listed in #90886