Remove allocation in GetPropertyAsDWord for CNG. #91521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsThe This changes the int32 path to work similarly to the intptr path and just get the value directly from p/invoke. Since the DWORD and HANDLE paths are exactly the same, use a generic implementation.
|
jkoritzinsky
approved these changes
Sep 3, 2023
bartonjs
approved these changes
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetPropertyAsDwordAPI was allocating a 4-byte array to convert it to an integer for p/invoke purposes.This changes the int32 path to work similarly to the intptr path and just get the value directly from p/invoke.
Since the DWORD and HANDLE paths are exactly the same, use a generic implementation.