Remove blocking on a test for native AOT #91781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see a problem with this locally. Fixes #89101.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsI don't see a problem with this locally. Fixes #89101.
|
jkotas
approved these changes
Sep 8, 2023
jkotas
requested changes
Sep 8, 2023
There was a problem hiding this comment.
The re-enabled test is failing to build with:
Generating native code
Unhandled Exception: System.Diagnostics.DebugProvider+DebugAssertException: at System.Diagnostics.DebugProvider.Fail(String, String) + 0x37
at System.Diagnostics.Debug.Fail(String, String) + 0x32
at ILCompiler.DependencyAnalysis.GenericVirtualMethodImplNode..ctor(MethodDesc) + 0xb0
at ILCompiler.DependencyAnalysis.NodeFactory.<>c.<CreateNodeCaches>b__38_17(MethodDesc method) + 0x23
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey, Func`2) + 0xb2
at ILCompiler.DependencyAnalysis.GVMDependenciesNode.SearchDynamicDependencies(List`1, Int32, NodeFactory) + 0x5d7
at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.DynamicDependencyNode.MarkNewDynamicDependencies(DependencyAnalyzer`2) + 0x42
at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ProcessMarkStack() + 0x24f
at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() + 0x4b
at ILCompiler.ILScanner.ILCompiler.IILScanner.Scan() + 0x14
at ILCompiler.Program.<Run>g__RunScanner|4_0(Program.<>c__DisplayClass4_0&) + 0x190
at ILCompiler.Program.Run() + 0x22a8
at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass221_0.<.ctor>b__0(ParseResult result) + 0x315
at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult) + 0xa5
at ilc!<BaseAddress>+0x637320
D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked\build\Microsoft.NETCore.Native.targets(302,5): error MSB3073: The command ""D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked\ilc-published\\ilc" @"D:\a\_work\1\s\artifacts\tests\coreclr/obj/windows.x64.Checked/Managed/Loader\classloader\StaticVirtualMethods\Regression\StaticVirtualsAndMethodConstraintsAndDefaultImplementation\native\StaticVirtualsAndMethodConstraintsAndDefaultImplementation.ilc.rsp"" exited with code 57005. [D:\a\_work\1\s\src\tests\Loader\classloader\StaticVirtualMethods\Regression\StaticVirtualsAndMethodConstraintsAndDefaultImplementation.csproj] [D:\a\_work\1\s\src\tests\build.proj]
jkotas
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see a problem with this locally. Fixes #89101.