Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mono] Avoid an assert when calling X86Base.Pause in non-llvm mode. #91828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 9, 2023

Fixes #91819.

@vargaz vargaz requested a review from fanyang-mono as a code owner September 9, 2023 00:08
@ghost ghost added the area-Codegen-JIT-mono label Sep 9, 2023
@ghost ghost assigned vargaz Sep 9, 2023
@vargaz vargaz requested a review from jandupej September 9, 2023 00:08
@SamMonoRT
Copy link
Member

cc @jandupej (possibly regressed due to #91393)

@vargaz
Copy link
Contributor Author

vargaz commented Sep 9, 2023

Will this need a backport ?

@SamMonoRT
Copy link
Member

SamMonoRT commented Sep 9, 2023

Will this need a backport ?

This is happening on main runs only (not on any backport PRs), so we should be good to submit on main only and not worry about backports. @LoopedBard3 - let me know if that changes in next 2-3 days.

@jandupej
Copy link
Contributor

jandupej commented Sep 9, 2023

Good catch, I must have missed this.

@vargaz vargaz merged commit 64a3c31 into dotnet:main Sep 9, 2023
@vargaz vargaz deleted the pause-no-llvm branch September 9, 2023 10:03
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][aot] MonoAOT BDN build crashing with SIGABRT
3 participants