Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 27, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20231205.11
  • Date Produced: December 6, 2023 5:56:19 AM UTC
  • Commit: 92a930f3247040ec9c077dac9bcdf0294745b339
  • Branch: refs/heads/main

…127.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.2
@ghost ghost added the area-codeflow for labeling automated codeflow label Nov 27, 2023
…127.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.3
…127.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.4
…127.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.6
…127.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.7
…127.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23577.8
…128.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.1
…128.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.2
…128.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.3
…128.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.8
…128.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.9
…129.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.2
…129.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.3
…129.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.4
…129.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.5
…129.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.6
…129.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.7
…129.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.8
…129.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.9
…129.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.10
…129.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.11
dotnet-maestro bot and others added 9 commits December 1, 2023 13:12
…201.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.2
…201.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.4
…201.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.6
…201.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.7
…201.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.8
…201.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.9
…202.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23602.1
…204.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.1
@lewing
Copy link
Member

lewing commented Dec 4, 2023

it looks like the new analyzer error is just assigning to a local that is not used again. I'm not really sure why it is a local in the first place though so it's possible this should be cleaned up more.

cc @stephentoub

@stephentoub
Copy link
Member

it looks like the new analyzer error is just assigning to a local that is not used again. I'm not really sure why it is a local in the first place though so it's possible this should be cleaned up more.

cc @stephentoub

Which analyzer? There's one about dead stores; I assume it's that one. Sounds like the code can just be cleaned up.

@lewing
Copy link
Member

lewing commented Dec 4, 2023

src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLDecimal.cs(1280,17): error IDE0059: (NETCORE_ENGINEERING_TELEMETRY=Build) Unnecessary assignment of a value to 'fMySignPos' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0059)

…204.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.3
dotnet-maestro bot and others added 8 commits December 5, 2023 01:07
…204.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.7
…204.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.9
…204.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.10
…204.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.11
…205.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.1
…205.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.2
…205.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.3
@akoeplinger
Copy link
Member

Out of curiosity I checked the internal TFS sources and the oldest copy I can find from late 2007 has exactly the same code with the fMySignPos being unnecessarily assigned so at least it's not some recent change :)

…205.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.9
…205.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.11
@akoeplinger
Copy link
Member

@dotnet-policy-service rerun

@akoeplinger akoeplinger merged commit 4d8dfff into main Dec 6, 2023
@akoeplinger akoeplinger deleted the darc-main-5f154009-9026-4ea5-8a74-0bdba385ea98 branch December 6, 2023 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants