Optimize a castclass over nullables #95764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsint Test<T>(T t) => ((IMyInterface)t).M();(for ; Assembly listing for method Program:Test[System.Nullable`1[S]](System.Nullable`1[S]):int
sub rsp, 40
mov qword ptr [rsp+0x30], rcx
lea rdx, [rsp+0x30]
mov rcx, 0xD1FFAB1E ; System.Nullable`1[S]
call CORINFO_HELP_BOX_NULLABLE
- mov rdx, rax
- mov rcx, 0xD1FFAB1E ; IMyInterface
- call CORINFO_HELP_CHKCASTINTERFACE
- mov rcx, rax
- mov r11, 0xD1FFAB1E ; code for IMyInterface:M():int:this
- call [r11]IMyInterface:M():int:this
- nop
+ movsx rax, byte ptr [rax+0x08]
+ mov eax, 42
add rsp, 40
ret
-; Total bytes of code 69
+; Total bytes of code 44
|
|
@dotnet/jit-contrib PTAL, no spmi diffs due to missing context this PR introduces. Jit-diffs are mostly size regressions because we devirtualize & inline more calls now, Example: |
AndyAyersMS
reviewed
Dec 8, 2023
AndyAyersMS
reviewed
Dec 8, 2023
Co-authored-by: Andy Ayers <[email protected]>
AndyAyersMS
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #50915
(for
TbeingNullable<S>); Assembly listing for method Program:Test[System.Nullable`1[S]](System.Nullable`1[S]):int sub rsp, 40 mov qword ptr [rsp+0x30], rcx lea rdx, [rsp+0x30] mov rcx, 0xD1FFAB1E ; System.Nullable`1[S] call CORINFO_HELP_BOX_NULLABLE - mov rdx, rax - mov rcx, 0xD1FFAB1E ; IMyInterface - call CORINFO_HELP_CHKCASTINTERFACE - mov rcx, rax - mov r11, 0xD1FFAB1E ; code for IMyInterface:M():int:this - call [r11]IMyInterface:M():int:this - nop + movsx rax, byte ptr [rax+0x08] + mov eax, 42 add rsp, 40 ret -; Total bytes of code 69 +; Total bytes of code 44