-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Limit PNSE
by using Invariant HashCode
in HybridGlobalization
#96354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7f5d711
Unblock all tests.
ilonatommy 709da38
SortKey is Invariant now.
ilonatommy 6e72858
Missing SortKey changes + fix HashCode.
ilonatommy 2d7a037
Typo
ilonatommy b896c17
Revert unbocking tests connected with CompareOptions PNSE.
ilonatommy de22e70
Hashing uses Invariant mode -these tests should be skipped.
ilonatommy 5778cd0
Add active issue.
ilonatommy d0666cd
feedback
ilonatommy 65236ab
Feedback
ilonatommy 0721f45
Better documentation.
ilonatommy 75586a0
Merge branch 'main' into fix-95921
ilonatommy 5625741
Add new tests + sanitize string before invariant comparison.
ilonatommy 90024bd
Comment + more cases.
ilonatommy 7acf408
Clean CI.
ilonatommy 89c55ad
Missing change for clean CI commit.
ilonatommy 9423bcc
`SortKey` not supported for non-invariant cultures, `HashCode` suppor…
ilonatommy 2887914
Feedback.
ilonatommy a599f77
Fix build, add docs.
ilonatommy c9dc938
Feedback @matouskozak @pavelsavara
ilonatommy bfb12b3
Merge branch 'main' into fix-95921
ilonatommy 398d047
Added tests + fixed algo.
ilonatommy ee1f542
Block failing tests for a follow-up PR.
ilonatommy 10e9060
Add more details to PNSE.
ilonatommy 80d9d37
Feedback - correct comment
ilonatommy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
SortKey is Invariant now.
- Loading branch information
commit 709da38f7b3cc003ca5c1c3d8247f78bf3f8cea0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.