Ensure small counts are properly handled for sizeof(T) == 8 #96463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves the CI failures being seen after #94555 was merged
|
stephentoub
reviewed
Jan 4, 2024
| case 1: | ||
| { | ||
| result = TAggregationOperator.Invoke(result, TTransformOperator.Invoke(xRef)); | ||
| goto case 0; |
There was a problem hiding this comment.
Why goto case 0 rather than break?
There was a problem hiding this comment.
The JIT doesn't do the best job at merging paths together, but it does fine at recognizing fallthrough patterns. Going to case 0 gives us a single fallthrough pattern with no branching that just naturally continues after the switch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the CI failures being seen after #94555 was merged