Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Clone newly recognized loops #96754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

JIT: Clone newly recognized loops #96754

merged 1 commit into from
Jan 12, 2024

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jan 10, 2024 •
edited
Loading

On our win-x64 collections this leads to around 800 more cloned loops (base: 24925, diff: 25775).

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2024
@ghost ghost assigned jakobbotsch Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on #96751

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Jan 10, 2024
Closed
21 tasks
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jakobbotsch jakobbotsch marked this pull request as ready for review January 11, 2024 11:29
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @BruceForstall

Diffs

On our win-x64 collections this leads to around 800 more cloned loops (base: 24925, diff: 25775). Likely we will also get some more cases when we fix

runtime/src/coreclr/jit/flowgraph.cpp

Lines 4959 to 4962 in 8f79b66

// TODO-Quirk: For backwards compatibility always try the lexically
// bottom-most block for the loop variable.
BasicBlock* bottom = GetLexicallyBottomMostBlock();
JITDUMP(" Bottom = " FMT_BB "\n", bottom->bbNum);

@AndyAyersMS AndyAyersMS mentioned this pull request Jan 12, 2024
Merged
@jakobbotsch jakobbotsch merged commit 3467066 into dotnet:main Jan 12, 2024
@jakobbotsch jakobbotsch deleted the clone-new-loops branch January 12, 2024 10:30
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@jakobbotsch @tmds
JIT: Clone newly recognized loops (dotnet#96754)
d6a8423 
On our win-x64 collections this leads to around 800 more cloned loops (base: 24925, diff: 25775).
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobbotsch @BruceForstall