Ensure that the Create(Dot(...)) optimization doesn't kick in for Vector2 pre SSE4.1 #96951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #96939
|
|
CC. @dotnet/jit-contrib for review, this fixes #96939 and will need consideration for backporting to .NET 8 |
|
Are you planning to backport the fix to 8.0 ? |
EgorBo
approved these changes
Jan 16, 2024
Yes, but it will need to wait for the March release. |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7550401659 |
4 tasks
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
…tor2 pre SSE4.1 (dotnet#96951) * Ensure that the Create(Dot(...)) optimization doesn't kick in for Vector2 pre SSE4.1 * Make sure to use #if defined(...) * Add missing using * Fix a type in the test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #96939