You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OidCollection class starts off with an internal array size of zero, then adjusts to 4, then adjusts to growing by a factor of 2. However, In many cases, we know the size of the OidCollection prior to it being created. In this scenario, we waste two calls to Array.Resize if the collection size is greater than 4, or one call if it is less than or equal to 4.
This pull request adds an internal size hint to the OidCollection so the backing array is appropriately sized from the beginning, and uses it in places where it is suitable to do so.
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.
Issue Details
The OidCollection class starts off with an internal array size of zero, then adjusts to 4, then adjusts to growing by a factor of 2. However, In many cases, we know the size of the OidCollection prior to it being created. In this scenario, we waste two calls to Array.Resize if the collection size is greater than 4, or one call if it is less than or equal to 4.
This pull request adds an internal size hint to the OidColleciton so the backing array is appropriated sized from the beginning, and uses it in places where it is suitable to do so.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this the conversation we had late last year about some perf problem that would be solved by avoiding growing the collection, or am I misremembering?
Is this the conversation we had late last year about some perf problem that would be solved by avoiding growing the collection, or am I misremembering?
I think you are misremembering. However I may be misremembering you misremembering.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OidCollectionclass starts off with an internal array size of zero, then adjusts to 4, then adjusts to growing by a factor of 2. However, In many cases, we know the size of theOidCollectionprior to it being created. In this scenario, we waste two calls toArray.Resizeif the collection size is greater than 4, or one call if it is less than or equal to 4.This pull request adds an internal size hint to the
OidCollectionso the backing array is appropriately sized from the beginning, and uses it in places where it is suitable to do so.