Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoiding loading and processing same cert file to improve cold start performance … #97267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Avoiding loading and processing same cert file to improve cold start performance … #97267

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0d0292
Avoiding processing same cert file to improve cold start performance …
Jan 21, 2024
87fbdae
Added Tuple to reuse FileStatus details
Jan 22, 2024
9efa5b7
Incorporated feedback
Jan 22, 2024
3f0980a
Kept the name same TryStat
Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Kept the name same TryStat
  • Loading branch information
Biroj committed Jan 22, 2024
commit 3f0980a00a4251d7e5127acd2982721c83b47fb1
11 changes: 4 additions & 7 deletions ...phy/src/System/Security/Cryptography/X509Certificates/OpenSslCachedSystemStoreProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private static bool LastWriteTimesHaveChanged()

if (s_rootStoreFile != null)
{
_ = TryStatFile(s_rootStoreFile, out DateTime lastModified);
_ = TryStatFile(s_rootStoreFile, out DateTime lastModified, out _);
if (lastModified != s_fileLastWrite)
{
return true;
Expand Down Expand Up @@ -366,16 +366,13 @@ private static string[] GetRootStoreDirectories(out bool isDefault)
return directories;
}

private static bool TryStatFile(string path, out DateTime lastModified)
=> CallStat(path, Interop.Sys.FileTypes.S_IFREG, out lastModified, out _);

private static bool TryStatDirectory(string path, out DateTime lastModified)
=> CallStat(path, Interop.Sys.FileTypes.S_IFDIR, out lastModified, out _);
=> TryStat(path, Interop.Sys.FileTypes.S_IFDIR, out lastModified, out _);

private static bool TryStatFile(string path, out DateTime lastModified, out (long, long) fileId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: only keep 1 TryStatFile and update the caller that ignores fileId by passing it out _ as the last argument.

=> CallStat(path, Interop.Sys.FileTypes.S_IFREG, out lastModified, out fileId);
=> TryStat(path, Interop.Sys.FileTypes.S_IFREG, out lastModified, out fileId);

private static bool CallStat(string path, int fileType, out DateTime lastModified, out (long, long) fileId)
private static bool TryStat(string path, int fileType, out DateTime lastModified, out (long, long) fileId)
{
lastModified = default;
fileId = default;
Expand Down