Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Vectorize TensorPrimitives shift and rotate operators #97361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Vectorize TensorPrimitives shift and rotate operators #97361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6083518
Vectorize TensorPrimitives shift and rotate operators
stephentoub Jan 23, 2024
92dc20c
Merge branch 'main' into vectorizemoreops
stephentoub Jan 28, 2024
c3b0507
Merge branch 'main' into vectorizemoreops
stephentoub Jan 29, 2024
695c8bb
Address PR feedback
stephentoub Jan 29, 2024
36d15c6
Address PR feedback
stephentoub Jan 29, 2024
8dc5d0c
Add more special value tests
stephentoub Jan 29, 2024
d47861a
Merge remote-tracking branch 'upstream/main' into vectorizemoreops
stephentoub Jan 29, 2024
d595cc0
Merge branch 'main' into vectorizemoreops
stephentoub Jan 29, 2024
237a097
Address PR feedback
stephentoub Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ public static void Round<T>(System.ReadOnlySpan<T> x, int digits, System.Span<T>
public static void Round<T>(System.ReadOnlySpan<T> x, System.MidpointRounding mode, System.Span<T> destination) where T : System.Numerics.IFloatingPoint<T> { }
public static void Round<T>(System.ReadOnlySpan<T> x, System.Span<T> destination) where T : System.Numerics.IFloatingPoint<T> { }
public static void ScaleB<T>(System.ReadOnlySpan<T> x, int n, System.Span<T> destination) where T : System.Numerics.IFloatingPointIeee754<T> { }
public static void ShiftLeft<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IBinaryInteger<T> { }
public static void ShiftRightArithmetic<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IBinaryInteger<T> { }
public static void ShiftRightLogical<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IBinaryInteger<T> { }
public static void ShiftLeft<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IShiftOperators<T, int, T> { }
public static void ShiftRightArithmetic<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IShiftOperators<T, int, T> { }
public static void ShiftRightLogical<T>(System.ReadOnlySpan<T> x, int shiftAmount, System.Span<T> destination) where T : System.Numerics.IShiftOperators<T, int, T> { }
public static void Sigmoid<T>(System.ReadOnlySpan<T> x, System.Span<T> destination) where T : System.Numerics.IExponentialFunctions<T> { }
public static void SinCosPi<T>(System.ReadOnlySpan<T> x, System.Span<T> sinPiDestination, System.Span<T> cosPiDestination) where T : System.Numerics.ITrigonometricFunctions<T> { }
public static void SinCos<T>(System.ReadOnlySpan<T> x, System.Span<T> sinDestination, System.Span<T> cosDestination) where T : System.Numerics.ITrigonometricFunctions<T> { }
Expand Down
131 changes: 15 additions & 116 deletions ...braries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.T.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2259,21 +2259,8 @@ public static void ReciprocalSqrtEstimate<T>(ReadOnlySpan<T> x, Span<T> destinat
/// </para>
/// </remarks>
public static void RootN<T>(ReadOnlySpan<T> x, int n, Span<T> destination)
where T : IRootFunctions<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = T.RootN(x[i], n);
}
}
where T : IRootFunctions<T> =>
InvokeSpanIntoSpan(x, new RootNOperator<T>(n), destination);

/// <summary>Computes the element-wise rotation left of numbers in the specified tensor by the specified rotation amount.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand All @@ -2287,21 +2274,8 @@ public static void RootN<T>(ReadOnlySpan<T> x, int n, Span<T> destination)
/// </para>
/// </remarks>
public static void RotateLeft<T>(ReadOnlySpan<T> x, int rotateAmount, Span<T> destination)
where T : IBinaryInteger<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = T.RotateLeft(x[i], rotateAmount);
}
}
where T : IBinaryInteger<T> =>
InvokeSpanIntoSpan(x, new RotateLeftOperator<T>(rotateAmount), destination);

/// <summary>Computes the element-wise rotation right of numbers in the specified tensor by the specified rotation amount.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand All @@ -2315,21 +2289,8 @@ public static void RotateLeft<T>(ReadOnlySpan<T> x, int rotateAmount, Span<T> de
/// </para>
/// </remarks>
public static void RotateRight<T>(ReadOnlySpan<T> x, int rotateAmount, Span<T> destination)
where T : IBinaryInteger<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = T.RotateRight(x[i], rotateAmount);
}
}
where T : IBinaryInteger<T> =>
InvokeSpanIntoSpan(x, new RotateRightOperator<T>(rotateAmount), destination);

/// <summary>Computes the element-wise rounding of the numbers in the specified tensor</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand Down Expand Up @@ -2414,22 +2375,12 @@ public static void Round<T>(ReadOnlySpan<T> x, int digits, MidpointRounding mode
}
}

if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

if ((uint)mode > (uint)MidpointRounding.ToPositiveInfinity)
{
throw new ArgumentException(SR.Format(SR.Argument_InvalidEnumValue, mode, typeof(MidpointRounding)), nameof(mode));
}

ValidateInputOutputSpanNonOverlapping(x, destination);

for (int i = 0; i < x.Length; i++)
{
destination[i] = T.Round(x[i], digits, mode);
}
InvokeSpanIntoSpan(x, new RoundOperator<T>(digits, mode), destination);
}

/// <summary>Computes the element-wise product of numbers in the specified tensor and their base-radix raised to the specified power.</summary>
Expand All @@ -2444,21 +2395,8 @@ public static void Round<T>(ReadOnlySpan<T> x, int digits, MidpointRounding mode
/// </para>
/// </remarks>
public static void ScaleB<T>(ReadOnlySpan<T> x, int n, Span<T> destination)
where T : IFloatingPointIeee754<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = T.ScaleB(x[i], n);
}
}
where T : IFloatingPointIeee754<T> =>
InvokeSpanIntoSpan(x, new ScaleBOperator<T>(n), destination);

/// <summary>Computes the element-wise shifting left of numbers in the specified tensor by the specified shift amount.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand All @@ -2472,21 +2410,8 @@ public static void ScaleB<T>(ReadOnlySpan<T> x, int n, Span<T> destination)
/// </para>
/// </remarks>
public static void ShiftLeft<T>(ReadOnlySpan<T> x, int shiftAmount, Span<T> destination)
where T : IBinaryInteger<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = x[i] << shiftAmount;
}
}
where T : IShiftOperators<T, int, T> =>
InvokeSpanIntoSpan(x, new ShiftLeftOperator<T>(shiftAmount), destination);

/// <summary>Computes the element-wise arithmetic (signed) shifting right of numbers in the specified tensor by the specified shift amount.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand All @@ -2500,21 +2425,8 @@ public static void ShiftLeft<T>(ReadOnlySpan<T> x, int shiftAmount, Span<T> dest
/// </para>
/// </remarks>
public static void ShiftRightArithmetic<T>(ReadOnlySpan<T> x, int shiftAmount, Span<T> destination)
where T : IBinaryInteger<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = x[i] >> shiftAmount;
}
}
where T : IShiftOperators<T, int, T> =>
InvokeSpanIntoSpan(x, new ShiftRightArithmeticOperator<T>(shiftAmount), destination);

/// <summary>Computes the element-wise logical (unsigned) shifting right of numbers in the specified tensor by the specified shift amount.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand All @@ -2528,21 +2440,8 @@ public static void ShiftRightArithmetic<T>(ReadOnlySpan<T> x, int shiftAmount, S
/// </para>
/// </remarks>
public static void ShiftRightLogical<T>(ReadOnlySpan<T> x, int shiftAmount, Span<T> destination)
where T : IBinaryInteger<T>
{
if (x.Length > destination.Length)
{
ThrowHelper.ThrowArgument_DestinationTooShort();
}

ValidateInputOutputSpanNonOverlapping(x, destination);

// TODO: Vectorize
for (int i = 0; i < x.Length; i++)
{
destination[i] = x[i] >>> shiftAmount;
}
}
where T : IShiftOperators<T, int, T> =>
InvokeSpanIntoSpan(x, new ShiftRightLogicalOperator<T>(shiftAmount), destination);

/// <summary>Computes the element-wise sigmoid function on the specified non-empty tensor of numbers.</summary>
/// <param name="x">The tensor, represented as a span.</param>
Expand Down
Loading