Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RISC-V] Implement replacing safe-point call instructions under GC_STRESS #97818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2024
Merged

[RISC-V] Implement replacing safe-point call instructions under GC_STRESS #97818

merged 3 commits into from
Feb 5, 2024

Conversation

tomeksowi
Copy link
Member

Fixes: DOTNET_GCStress=4 JIT/Methodical/tailcall/deep_array_nz_r/deep_array_nz_r.sh

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

yurai007 and others added 2 commits February 1, 2024 15:28
@yurai007 @tomeksowi
[RISC-V] Fix the System.NullReferenceException: Object reference not …
c704d29 
…set to an instance of an object. in Methodical_r2.sh-deep_array_nz_r.dll when DOTNET_GCStress=4.
@tomeksowi
[RISC-V] Implement correctly replacing safe-point instructions under …
7a2a7f7 
…GC_STRESS and getting the target of call instructions jal and jalr
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 1, 2024
@ghost
Copy link

ghost commented Feb 1, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: DOTNET_GCStress=4 JIT/Methodical/tailcall/deep_array_nz_r/deep_array_nz_r.sh

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

Author: tomeksowi
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

tomeksowi
tomeksowi commented Feb 1, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Feb 1, 2024
Closed
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Feb 2, 2024
@tomeksowi tomeksowi marked this pull request as ready for review February 2, 2024 06:43
@clamp03 clamp03 requested a review from jkotas February 5, 2024 00:23
jkotas
jkotas approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit c3940f6 into dotnet:main Feb 5, 2024
@brucehoult
Copy link

LGTM

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

+1 more reviewer

@clamp03 clamp03 clamp03 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomeksowi @brucehoult @clamp03 @jkotas @yurai007