Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement faster RSA key check #97827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Implement faster RSA key check #97827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
635a083
Implement faster RSA key check
vcsjones Feb 1, 2024
b622f50
Self code review
vcsjones Feb 1, 2024
85c2ab0
Fix ordering of defines
vcsjones Feb 2, 2024
279466f
Code review feedback
vcsjones Feb 2, 2024
e1bedbe
More code review feedback
vcsjones Feb 2, 2024
08e1b92
Merge branch 'main' into ossl-fast-pkey-check
vcsjones Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Self code review
  • Loading branch information
@vcsjones
vcsjones committed Feb 1, 2024
commit b622f5012b8196299704ff5777cec3f8dc529687
2 changes: 1 addition & 1 deletion src/native/libs/System.Security.Cryptography.Native/apibridge.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ int local_BN_is_zero(const BIGNUM* a)

int local_BN_is_one(const BIGNUM* a)
{
return BN_abs_is_word(a, 1) && !a->neg;
return BN_abs_is_word(a, 1) && !a->neg;
}

int local_BN_abs_is_word(const BIGNUM *a, const BN_ULONG w)
Expand Down
10 changes: 6 additions & 4 deletions src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,12 @@ static int32_t QuickRsaCheck(const RSA* rsa, bool isPublic)
goto done;
}

ctx = BN_CTX_new();

// Setup the scratch integers
if ((x = BN_new()) == NULL || (y = BN_new()) == NULL || (p1 = BN_new()) == NULL || (q1 = BN_new()) == NULL)
// Set up the scratch integers
if ((ctx = BN_CTX_new()) == NULL ||
(x = BN_new()) == NULL ||
(y = BN_new()) == NULL ||
(p1 = BN_new()) == NULL ||
(q1 = BN_new()) == NULL)
{
goto done;
}
Expand Down