Skip long values when building Rabin-Karp buckets in SearchValues #98901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-buffers Issue DetailsWe already have an optimization that skips building the buckets altogether if all the values are longer than
|
stephentoub
reviewed
Feb 25, 2024
src/libraries/System.Private.CoreLib/src/System/SearchValues/Strings/Helpers/RabinKarp.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 25, 2024
45ca924 to
09eba1b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have an optimization that skips building the buckets altogether if all the values are longer than
MaxInputLength.This change excludes such long values that can never match if we do end up building the buckets, slightly reducing memory consumption, as well as potentially reducing the amount of wasted confirmations we have to do when searching.