Remove use of POH for cryptographic primitives #99168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsIn some cryptographic primitives, we used the POH to pin arrays so that the underlying key material would not get moved around by the GC, which would allow for more effective zeroing of key material. Based on feedback in #97447, this pattern turned out to be undesirable. This replaces the uses of the POH with native memory.
|
bartonjs
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cryptographic primitives, we used the POH to pin arrays so that the underlying key material would not get moved around by the GC, which would allow for more effective zeroing of key material.
Based on feedback in #97447, this pattern turned out to be undesirable. This replaces the uses of the POH with native memory.