Start moving over to official templates #99433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cc6b72 to
408ad80
Compare
e7356ff to
8cb76a6
Compare
This was referenced Mar 26, 2024
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines failed to run 1 pipeline(s). |
akoeplinger
approved these changes
Mar 27, 2024
| ${{ if and(or(in(parameters.osGroup, 'linux', 'freebsd', 'android', 'tizen'), eq(parameters.jobParameters.hostedOs, 'linux')), ne(variables['System.TeamProject'], 'public')) }}: | ||
| name: $(DncEngInternalBuildPool) | ||
| demands: ImageOverride -equals Build.Ubuntu.2204.Amd64 | ||
| demands: ImageOverride -equals 1es-ubuntu-2204 |
There was a problem hiding this comment.
the Build.Ubuntu.2204.Amd64 image should get the 1ES prerequisites in today's rollout: dotnet/dnceng#2113 ?
There was a problem hiding this comment.
I'll leave this for later cleanup rather than depend on the rollout.
directhex
reviewed
Mar 27, 2024
akoeplinger
reviewed
Mar 28, 2024
akoeplinger
reviewed
Mar 28, 2024
This was referenced Mar 29, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Start moving over to official templates * Parameterize runtime-inner-loop * Use default false for isOfficialBuild in pipeline-with-resources * Respond to PR comments * Code review comments * Use default template args
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this successfully ports over all major scenarios. It's certainly possible some of the outerloops will break. I'm happy to do some up-front work to scout the outerloops, but I'm not going to block on them all being done before moving us over.