Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Initialize values for yield normalization during startup #99991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Initialize values for yield normalization during startup #99991

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cdebbfe
Add initialization for yield normalization
eduardo-vp Mar 21, 2024
acd40a5
Fix code
eduardo-vp Mar 21, 2024
b37ffcd
Add yieldprocessornormalized.h
eduardo-vp Mar 26, 2024
1a90ad8
Comment changes in ceemain.cpp to see effect on pipelines
eduardo-vp Mar 27, 2024
13c0161
Revert "Comment changes in ceemain.cpp to see effect on pipelines"
eduardo-vp Mar 27, 2024
ea46a91
Check IsGCHeapInitialized
eduardo-vp Mar 28, 2024
c3ffb0a
Rename method
eduardo-vp Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check IsGCHeapInitialized
  • Loading branch information
@eduardo-vp
eduardo-vp committed Mar 28, 2024
commit ea46a9122d5090698a665d75cd593e231a760acb
2 changes: 2 additions & 0 deletions src/coreclr/inc/yieldprocessornormalized.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class YieldProcessorNormalization
return s_isMeasurementScheduled;
}

static void GCHeapSetYieldProcessorScalingFactor();

static void PerformMeasurement();

private:
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/vm/ceemain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,8 @@ void EEStartupHelper()
LogErrorToHost("GC heap initialization failed with error 0x%08X", hr);
}

YieldProcessorNormalization::GCHeapSetYieldProcessorScalingFactor();

IfFailGo(hr);

#ifdef FEATURE_PERFTRACING
Expand Down
10 changes: 9 additions & 1 deletion src/coreclr/vm/yieldprocessornormalized.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ static double MeasureNsPerYield(unsigned int measureDurationUs)
return Max(MinNsPerYield, Min((double)elapsedTicks * NsPerS / ((double)yieldCount * ticksPerS), MaxNsPerYield));
}

void YieldProcessorNormalization::GCHeapSetYieldProcessorScalingFactor()
{
if (GCHeapUtilities::IsGCHeapInitialized())
{
GCHeapUtilities::GetGCHeap()->SetYieldProcessorScalingFactor((float)s_yieldsPerNormalizedYield);
}
}

void YieldProcessorNormalization::PerformMeasurement()
{
CONTRACTL
Expand Down Expand Up @@ -217,7 +225,7 @@ void YieldProcessorNormalization::PerformMeasurement()
Max(1u, (unsigned int)(TargetMaxNsPerSpinIteration / (yieldsPerNormalizedYield * establishedNsPerYield) + 0.5));
_ASSERTE(s_optimalMaxNormalizedYieldsPerSpinIteration <= MaxOptimalMaxNormalizedYieldsPerSpinIteration);

GCHeapUtilities::GetGCHeap()->SetYieldProcessorScalingFactor((float)yieldsPerNormalizedYield);
GCHeapSetYieldProcessorScalingFactor();

if (s_normalizationState != NormalizationState::Uninitialized)
{
Expand Down