Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't place unconstructed EETypes in the types hashtable #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

Don't place unconstructed EETypes in the types hashtable #1319

merged 1 commit into from
Jul 13, 2021

Conversation

MichalStrehovsky
Copy link
Member

We shouldn't need to see the unconstructed types at runtime for anything.

Fixes #1262.

@MichalStrehovsky
Don't place unconstructed EETypes in the types hashtable
ceffe37 
We shouldn't need to see the unconstructed types at runtime for anything.

Fixes dotnet#1262.
@MichalStrehovsky MichalStrehovsky added the area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation label Jul 13, 2021
@MichalStrehovsky MichalStrehovsky requested a review from jkotas July 13, 2021 13:37
jkotas
jkotas approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does the linked issue fail with missing metadata exception now?

@MichalStrehovsky
Copy link
Member Author

Thanks. Does the linked issue fail with missing metadata exception now?

Yup:

Unhandled Exception: System.Reflection.MissingMetadataException: 'System.Func<System.Int32>' is missing metadata. For more information, please visit http://go.microsoft.com/fwlink/?LinkID=392859
   at System.Reflection.Runtime.General.TypeUnifier.WithVerifiedTypeHandle(RuntimeConstructedGenericTypeInfo, RuntimeTypeInfo[]) + 0x19a
   at System.Reflection.Runtime.General.TypeUnifier.GetConstructedGenericTypeWithTypeHandle(RuntimeTypeInfo, RuntimeTypeInfo[]) + 0x3e
   at System.Reflection.Runtime.TypeInfos.RuntimeTypeInfo.MakeGenericType(Type[]) + 0x4b0
   at System.Linq.Expressions.Compiler.DelegateHelpers.GetFuncType(Type[]) + 0xc8
   at System.Linq.Expressions.Compiler.DelegateHelpers.MakeNewDelegate(Type[]) + 0x1c0
   at System.Linq.Expressions.Compiler.DelegateHelpers.MakeDelegateType(Type[]) + 0xf5
   at System.Linq.Expressions.Expression.Lambda(Expression, String, Boolean, IEnumerable`1) + 0x2cc
   at System.Linq.Expressions.Expression.Lambda(Expression, Boolean, IEnumerable`1) + 0x32
   at System.Linq.Expressions.Expression.Lambda(Expression, ParameterExpression[]) + 0x27
   at LiteDB.LinqExpressionVisitor.Evaluate(Expression, Type[]) + 0x102
   at LiteDB.LinqExpressionVisitor.VisitBinary(BinaryExpression) + 0x3df
   at System.Linq.Expressions.BinaryExpression.Accept(ExpressionVisitor) + 0x33
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression) + 0x42
   at System.Linq.Expressions.ExpressionVisitor.VisitLambda[T](Expression`1) + 0x6b
   at LiteDB.LinqExpressionVisitor.VisitLambda[T](Expression`1) + 0x45
   at System.Linq.Expressions.Expression`1.Accept(ExpressionVisitor) + 0x7a
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression) + 0x42
   at LiteDB.LinqExpressionVisitor.Resolve(Boolean) + 0x67
   at LiteDB.BsonMapper.GetExpression[T, K](Expression`1) + 0xa7
   at LiteDB.LiteCollection`1.Exists(Expression`1) + 0x5e
   at ConsoleApp1.Program.Main(String[]) + 0x646
   at reproNative!<BaseAddress>+0x7198d7
   at reproNative!<BaseAddress>+0x719960

@MichalStrehovsky MichalStrehovsky merged commit a5a150a into dotnet:feature/NativeAOT Jul 13, 2021
@MichalStrehovsky MichalStrehovsky deleted the fix1262 branch July 13, 2021 17:14
@MichalStrehovsky MichalStrehovsky mentioned this pull request Jul 13, 2021
Closed
@MichalStrehovsky MichalStrehovsky mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalStrehovsky @jkotas