Testing new macos lane #3953
Merged
Testing new macos lane #3953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34d6ea2 to
04612e0
Compare
04612e0 to
46c775a
Compare
b91aabd to
9d8f659
Compare
|
Under the scenario where both a mono sample and non-mono sample are modified in the same pull request, is there a way to run the original build validation without the mono sample changes? achieves this. |
akoeplinger
approved these changes
Nov 17, 2020
I think you'll need to tweak the Get-MSBuildResults.ps1 script to exclude certain paths. |
1f8737e to
c97b717
Compare
c97b717 to
58ae03a
Compare
7a44a71 to
e72c8fc
Compare
steveisok
approved these changes
Nov 18, 2020
e72c8fc to
7ab52c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the import of
dotnet/runtimesamples that demonstrate how to build iOS, Android, and wasm apps on top of the mono runtime, a check to ensure that these have built properly is needed. The mono samples need to pull down a runtime pack to properly build the application, sodotnet publishwill be used instead ofdotnet build.The applications will not be ran for these checks. Ensuring that the applications can be built is the primary goal.
This PR looks to add another GitHub Actions workflow that targets these mono-samples.
When a file that influences the publish process is changed, the original build shall not be ran for the project, instead, the new one will be ran.
As seen in this PR, the original build check does not run for this PR, only
Publish Mono Samplesis ran.