Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Oct 4, 2022

Description

Fixes issue where after updating from Preview 7, workload install commands would fail with a KeyNotFoundException.

Fixes #28217

Regression

Yes - this is a behavior regression from previous previews. The code didn't regress recently, rather we renamed workload packs in RC1 which exposed a preexisting bug in the code.

Risk

Low

Testing

  • manual testing
  • updated automated tests cases to cover scenario where workload pack was renamed

@dsplaisted dsplaisted requested review from joeloff, nagilson and a team October 4, 2022 18:30
@ghost ghost added the Area-Workloads label Oct 4, 2022
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A regression test would be ideal but sounds like that'd be a lot of work!
Also, we have been seeing that pipeline failure with RazorSDK files being in use a lot recently.

@dsplaisted
Copy link
Member Author

@marcpopMSFT Did you have a fix for the below, or was that for something else? If we don't have a fix this could go on a list of build reliability things to look at.

D:\a\1\s\src\RazorSdk\Tasks\Microsoft.NET.Sdk.Razor.Tasks.csproj(107,5): error MSB3026: Could not copy "D:\a\1\s\src\RazorSdk\Targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets" to "D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets". Beginning retry 1 in 1000ms. The process cannot access the file 'D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets' because it is being used by another process. [TargetFramework=net472]
##[error]src\RazorSdk\Tasks\Microsoft.NET.Sdk.Razor.Tasks.csproj(107,5): error MSB3026: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy "D:\a\1\s\src\RazorSdk\Targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets" to "D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets". Beginning retry 1 in 1000ms. The process cannot access the file 'D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.StaticWebAssets.Pack.CrossTargeting.targets' because it is being used by another process.
D:\a\1\s\src\RazorSdk\Tasks\Microsoft.NET.Sdk.Razor.Tasks.csproj(107,5): error MSB3026: Could not copy "D:\a\1\s\src\RazorSdk\Targets\Rules\RazorComponentWithTargetPath.xaml" to "D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Rules\RazorComponentWithTargetPath.xaml". Beginning retry 1 in 1000ms. The process cannot access the file 'D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Rules\RazorComponentWithTargetPath.xaml' because it is being used by another process. [TargetFramework=net7.0]
##[error]src\RazorSdk\Tasks\Microsoft.NET.Sdk.Razor.Tasks.csproj(107,5): error MSB3026: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy "D:\a\1\s\src\RazorSdk\Targets\Rules\RazorComponentWithTargetPath.xaml" to "D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Rules\RazorComponentWithTargetPath.xaml". Beginning retry 1 in 1000ms. The process cannot access the file 'D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\targets\Rules\RazorComponentWithTargetPath.xaml' because it is being used by another process.

@dsplaisted
Copy link
Member Author

A regression test would be ideal but sounds like that'd be a lot of work! Also, we have been seeing that pipeline failure with RazorSDK files being in use a lot recently.

I did update the data used by existing workload update tests to cover this scenario, so we do have regression coverage.

@nagilson
Copy link
Member

nagilson commented Oct 7, 2022

I've been meaning to make a list of build reliability things, will add this to that later today

@nagilson nagilson merged commit f094391 into dotnet:release/7.0.1xx Oct 7, 2022
@nagilson
Copy link
Member

nagilson commented Oct 7, 2022

approved via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants