Allow ResolveReadyToRunCompilers to be run under FreeBSD #31581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Matching runtime PR (also by @sec ) here: dotnet/runtime#84250 |
This was referenced Apr 4, 2023
|
Should this be changed to match it's runtime version - ex. dotnet/runtime@1b6d95b ? |
|
Not code owner, but the note states that it should be sync'd with runtime which I read as "match" |
|
Pushed changes to match with runtime code. |
|
Looks like ready to be merged? |
|
The SDK that contains this change fails to build the ILCompiler project. This is a blocking issue for the RC1 release. See dotnet/source-build#3568 |
jkotas
added a commit
that referenced
this pull request
Jul 26, 2023
)" This reverts commit 0f2f0b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable almost patchless build of runtime under FreeBSD, with R2R. @Thefrank