Fix Source Link cross-targeting targets #33292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsplaisted PTAL |
|
Can you please add a test that protects the behavior for multi-targeting and non multi-targeting projects? |
|
@ViktorHofer Will do that as a follow-up: #33297 |
dsplaisted
approved these changes
Jun 16, 2023
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props
Show resolved
Hide resolved
To unblock Arcade updates ASAP. I might be able to add the test today though. |
|
Arcade is blocked anyway for about a month until the next (signed) preview that contains this fix releases. We meanwhile reverted the PackageReference change in Arcade. |
|
OK, go ahead and merge if you'd like. |
|
Added a test - figured I can reuse the existing one, just add packaging validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsCrossTargetingBuildis only defined in.targets, not in.props.Only
Microsoft.SourceLink.Common.targetsneeds to be imported in cross-targeting build as it contains workaround for dotnet/msbuild#3294. Once this issue is fixed we can remove cross-targeting specialization entirely.Related: dotnet/msbuild#8898
Fixes #33297