[ApiDiff] Update symbol filtering code to be able to load a list of strings or a list of files #46255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…both for Attribute filtering or for API filtering.
ViktorHofer
reviewed
Jan 24, 2025
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/DocIdSymbolFilter.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 24, 2025
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/DocIdSymbolFilter.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 24, 2025
test/Microsoft.DotNet.ApiCompatibility.Tests/Microsoft.DotNet.ApiCompatibility.Tests.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 24, 2025
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/SymbolFilterFactory.cs
Show resolved
Hide resolved
This was referenced Jan 25, 2025
Open
ViktorHofer
reviewed
Jan 27, 2025
src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ApiCompatServiceProvider.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 27, 2025
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/SymbolFilterFactory.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 27, 2025
src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ApiCompatServiceProvider.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 27, 2025
test/Microsoft.DotNet.ApiCompatibility.Tests/Rules/AttributesMustMatchTests.cs
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
This change adds the ability to load DocIDs for consumption in API or Attribute symbol filtering and simplifies the code. It also updates the locations where this was being used.
This code will be reused by ApiDiff in a very similar way as in GenAPI, and the methods that generate filters from files or from lists needed to be clearly separated.
Please review ignoring whitespace as VS Code keeps insisting on removing it automatically in files I modify.