-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WiX 5] Migrate SDK from v3 to v5 #48699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
</PropertyGroup> | ||
<PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</PropertyGroup> | |
<PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank, but this PR is not ready for review. This will go away complete. This is working around internal code flow delays and testing against externals that are not built and overriding our Arcade defaults.
Overview
This PR migrates the .NET SDK from WiX 3.14 to using 5.0.2. The package used is different from the public toolset and built from source.
Changes
dotnet-sdk.proj
and assign anIdle
target. This allows the projects to participate in restore operations, but avoids being built as an actual reference. The projects depend on various values that are unavailable when project references are resolved.generate*.ps1
scripts that previously invokedCandle
andLight
. These tools no longer exist in v5.UI changes
WixBundleAction
.Hypertext
elements. Only one link per control to ensure tab order is consistent.lang
option.Finalizer
ExePackage
authoring for more details).None
)TODO:
Missing localization strings:
[047C:1328][2025-06-20T14:01:14]i000: WIXSTDBA: Missing loc string '#(loc.FilesInUseTitle)'.
[047C:1328][2025-06-20T14:01:14]i000: WIXSTDBA: Missing loc string '#(loc.FilesInUseRetryButton)'.
[047C:1328][2025-06-20T14:01:14]i000: WIXSTDBA: Missing loc string '#(loc.FilesInUseIgnoreButton)'.
[047C:1328][2025-06-20T14:01:14]i000: WIXSTDBA: Missing loc string '#(loc.FilesInUseExitButton)'.
[047C:1328][2025-06-20T14:01:14]i000: WIXSTDBA: Missing loc string '#(loc.FilesInUseNetfxCloseRadioButton)'.