Thanks to visit codestin.com
Credit goes to github.com

Skip to content

reference-list: Expand includes #49168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

edvilme
Copy link
Contributor

@edvilme edvilme commented May 27, 2025

Fixes #49127

Currently, the command lists references without evaluating them, resulting in MSBuild syntax showing up in the command result.

This attempts to fix that.

@edvilme
Copy link
Contributor Author

edvilme commented May 27, 2025

This uses the same method as sln-add

@marcpopMSFT
Copy link
Member

Missed in our May redistribution. @MiYanni mind taking a look at finishing this off?

MiYanni added 2 commits June 25, 2025 16:18
… a test that doesn't work because dotnet add reference doesn't evaluate input. Fixed name of VS shortcut to match sdk.slnx on disk. Fixed arrangement of projects in sdk.slnx.
Copy link
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

…ia XML editing to the test, so it passes properly.
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for getting this closed out!

@baronfel baronfel enabled auto-merge (squash) June 27, 2025 22:02
@baronfel baronfel merged commit f8d955d into dotnet:main Jun 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet list reference returns non expanded paths
5 participants