Set publishDir for file based apps #49514
Conversation
|
@dotnet/run-file for review please |
There was a problem hiding this comment.
Pull Request Overview
Updates the default publish directory for file-based apps and adds tests to verify the new behavior.
- Adds a
<PublishDir>MSBuild property to the virtual project template. - Updates existing publish tests to assert on the new
artifacts/<ProjectName>layout. - Introduces new tests covering custom publish directory scenarios (default, CLI override, and property directive).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Switches tests to use publishDir and adds new publish-dir tests |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Sets default <PublishDir>artifacts/$(MSBuildProjectName)</PublishDir> in generated project |
| @@ -536,6 +536,7 @@ public static void WriteProjectFile( | |||
| <PropertyGroup> | |||
| <IncludeProjectNameInArtifactsPaths>false</IncludeProjectNameInArtifactsPaths> | |||
| <ArtifactsPath>{EscapeValue(artifactsPath)}</ArtifactsPath> | |||
| <PublishDir>artifacts/$(MSBuildProjectName)</PublishDir> | |||
There was a problem hiding this comment.
I assume this is relative to the "current csproj file", not "current working directory", right? So running dotnet publish ./subdir/app.cs would result in ./subdir/publish/artifacts/app/app.exe and not ./publish/artifacts/app/app.exe. Consider adding a test for that.
There was a problem hiding this comment.
The file name of the project file without the file name extension; for example, MyApp.
RE PublishDir, I believe it's relative to working directory, but I can't find docs for it.
There was a problem hiding this comment.
Seems it maps to OutputPath:
There was a problem hiding this comment.
OK, yes it's relative to the project directory:
Specifies the path to the output directory, relative to the project directory, for example, bin\Debug or bin\Debug$(Platform) in non-AnyCPU builds.
There was a problem hiding this comment.
Added a test to confirm and cover behavior.
Fixes: #49387