Better organize dotnet-watch source files and clean up #49524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @@tmat. |
5bcc521 to
9371aab
Compare
This was referenced Jun 25, 2025
tmat
commented
Jun 25, 2025
| /// <param name="searchBase">The base directory to search</param> | ||
| /// <param name="project">The filename of the project. Can be null.</param> | ||
| /// </summary> | ||
| public static string FindMsBuildProject(string searchBase, string? project) |
tmat
commented
Jun 25, 2025
|
|
||
| namespace Microsoft.DotNet.Watch; | ||
|
|
||
| internal class ReporterTraceListener(IReporter reporter, string emoji) : TraceListener |
tmat
commented
Jun 25, 2025
| @@ -342,5 +342,27 @@ public async Task ProjectGraphLoadFailure() | |||
| App.AssertOutputContains(@"dotnet watch ⌚ Failed to load project graph."); | |||
| App.AssertOutputContains($"dotnet watch ❌ The project file could not be loaded. Could not find a part of the path '{Path.Combine(testAsset.Path, "AppWithDeps", "NonExistentDirectory", "X.csproj")}'"); | |||
| } | |||
|
|
|||
| [PlatformSpecificFact(TestPlatforms.Windows)] // "https://github.com/dotnet/sdk/issues/49307") | |||
| public async Task ListsFiles() | |||
tmat
commented
Jun 25, 2025
|
|
||
| namespace Microsoft.DotNet.Watch.UnitTests; | ||
|
|
||
| internal class TestBuildEvaluator(DotNetWatchContext context, MSBuildFileSetFactory factory) |
tmat
commented
Jun 25, 2025
| @@ -115,12 +115,5 @@ public async Task ProcessAsync_SetsEvaluationRequired_IfMSBuildFileChanges_ButIs | |||
|
|
|||
| Assert.True(evaluator.RequiresRevaluation); | |||
| } | |||
|
|
|||
tmat
commented
Jun 25, 2025
| @@ -103,28 +103,6 @@ public async Task ChangeExcludedFile() | |||
| Assert.NotSame(fileChanged, finished); | |||
| } | |||
|
|
|||
| [PlatformSpecificFact(TestPlatforms.Windows)] // "https://github.com/dotnet/sdk/issues/49307") | |||
|
@DustinCampbell ptal |
DustinCampbell
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates
--no-hot-reloadwatcher from Hot Reload. There is no need for a shared subclass.Prepares for elimination of
MSBuildFileSetFactoryfrom Hot Reload watcher.New layout:
