Remove Aspire Workload and Add Deprecation Warning for .NET 10 SDK #49534
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the Aspire workload, introduces a deprecation warning for any manual Aspire install attempts, and updates related tests, manifests, and localized resources.
- Removed Aspire entries from workload manifests, layout targets, version props, and CLI string resources.
- Updated existing tests to drop Aspire expectations and added new tests verifying the deprecation warning.
- Enhanced
WorkloadInstallCommandto filter out "aspire" and emit a one-time deprecation message.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Workload/Install/WorkloadInstallCommand.cs | Added logic to skip "aspire" and show deprecation |
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Added new resource string for Aspire deprecation |
| src/Layout/redist/targets/BundledManifests.targets | Removed Aspire workload from bundled manifests |
| eng/Versions.props | Removed Aspire feature band and manifest version |
| test/dotnet.Tests/.../GivenDotnetWorkloadUpdate.cs | Updated workload update tests to drop Aspire |
| test/dotnet.Tests/.../WorkloadInstallAspireDeprecationTests.cs | Added tests for Aspire deprecation warning |
| test/dotnet-MsiInstallation.Tests/... | Replaced Aspire references with wasm-tools in tests |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.*.xlf | Inserted new translation stubs for deprecation msg |
| documentation/general/workloads/workload-diagnosis.md | Removed outdated Aspire mention from docs |
Comments suppressed due to low confidence (1)
src/Cli/dotnet/Commands/Workload/Install/WorkloadInstallCommand.cs:72
- [nitpick] Consider renaming this method to reflect its side effects (filtering IDs and logging a deprecation message), e.g.,
FilterWorkloadIdsAndShowDeprecation, to make its intent clearer.
private IReadOnlyCollection<string> GetValidWorkloadIds()
src/Cli/dotnet/Commands/Workload/Install/WorkloadInstallCommand.cs
Outdated
Show resolved
Hide resolved
…point them to docs to upgrade to new aspire sdk.
|
In my latest commit, I also added a new warning that will be displayed for projects that depend on the old aspire workload, with instructions on how to upgrade. Here is how that looks like after these changes:
|
src/Cli/dotnet/Commands/Workload/Install/WorkloadInstallCommand.cs
Outdated
Show resolved
Hide resolved
| Detection logic: | ||
| - IsAspireHost='true' indicates this is an Aspire host project | ||
| - AspireHostingSDKVersion is set by Aspire.AppHost.Sdk in new projects (9.0.0+) | ||
| - If AspireHostingSDKVersion is missing or < 9.0.0, this is likely an old workload-based project |
There was a problem hiding this comment.
you say likely here. Are there any scenarios where we'd be giving customers a build error if we shouldn't?
There was a problem hiding this comment.
There is a very unlikely scenario where the new MSBuild SDK doesn't restore properly, and since that is the thing that defines AspireHostingSDKVersion you could run into a situation where the project is using the new aspire but didn't detect this property (as the sdk failed to load/restore) so in that case it would be a false positive. Worth noting that while we've had reports of this happening once or twice in the past, we have never been able to repro it.
Fixes #49278
Eliminate the Aspire workload and its associated manifest. Introduce a warning message for users attempting to manually install the Aspire workload, guiding them to alternative options.
Here is the experience of running a few of the workload commands after these changes:
cc: @baronfel, @marcpopMSFT, @DamianEdwards, @davidfowl, @maddymontaquila