The pull request label check wasn't getting run when a draft PR was published #49546
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiYanni
reviewed
Jun 25, 2025
MiYanni
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
All I did was read the document on pull_request_target. I learned that this was chosen because of this sentence:
This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the
pull_requestevent does.
So, there's no reason to use/add pull_request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copilot creates it's PRs in draft mode and then we publish after discussion. I noticed that the branch lockdown check wouldn't end up getting run and I'd have to force it to run. This should fix that I believe.