-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release/9.0.1xx] Update dependencies from dotnet/templating #49548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0.1xx
Are you sure you want to change the base?
[release/9.0.1xx] Update dependencies from dotnet/templating #49548
Conversation
…0250623.4 Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25323.4
Notification for subscribed users from https://github.com/dotnet/templating:@dotnet/templating-engine-maintainers Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…0250625.2 Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25325.2
@MiYanni, @marcpopMSFT, most GivenThatWeWantToBuild test cases fail because of the following reasons:
When the lock is released, I want to bring 2a856e5 and 48a2a31 to release/9.0.1xx branch to fix the test failure. What do you think about this? The same issue in PR 49535. |
So you want to back port the test change that updates a bunch of tests to target netstandard2.0 instead of netstandard1.5? That seems like a reasonable thing to do. You could cherry pick that change into this branch and see if it passes checks fwiw. I guess it's possible targeting an older netstandard could break but we recommend 2.0 or 2.1 so I'm not too worried about the lost coverage. |
…0250627.1 Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25327.1
This pull request updates the following dependencies
From https://github.com/dotnet/templating