Update test template tests #49554
Merged
Update test template tests #49554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the RecordPackages logic in DotnetNewTestTemplatesTests.cs to use a structured Component Detection Manifest (JSON schema) instead of a simple version dictionary, moves the test packages file to a dedicated TestPackages directory, and introduces model classes for serialization.
- Moved
packages.jsonpath totest/TestPackagesand added an initial empty manifest file. - Replaced dictionary-based package version tracking with
ComponentDetectionManifestand related types. - Updated serialization/deserialization logic and added guards to avoid overwriting on parse errors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs | Reworked RecordPackages to use a manifest model and JSON attributes, added CreateNewManifest helper and nested classes |
| test/TestPackages/packages.json | Added new empty manifest stub for tests |
Comments suppressed due to low confidence (2)
test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs:348
- The initializer
[]is not valid for aList<Registration>. Use a proper list constructor, for exampleRegistrations = new List<Registration>().
[]
test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs:310
- You cannot assign through a null-conditional operator. Ensure
ComponentandNugetare non-null and then assign directly, e.g.:existingRegistration.Component.Nuget.Version = version;.
existingRegistration.Component?.Nuget?.Version = version;
fhnaseer
approved these changes
Jun 25, 2025
MarcoRossignoli
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
RecordPackagesmethod inDotnetNewTestTemplatesTests.csto use a structuredComponentDetectionManifestformat instead of a simple dictionary for tracking package versions. It also introduces new helper classes to model the manifest structure and updates the logic to handle existing manifests more robustly. Additionally, thepackages.jsonfile has been moved to a new directory, and the code now ensures proper serialization with camelCase naming.Refactoring
RecordPackagesMethod:ComponentDetectionManifestformat, including support for registrations and component details. [1] [2] [3]Manifest Structure Enhancements:
ComponentDetectionManifest,Registration,Component,NugetComponent) to model the manifest structure and added JSON serialization attributes for camelCase naming.File Path Update:
PackagesJsonPathto point to the new directorytest/TestPackages/packages.json, reflecting the relocation of thepackages.jsonfile.New
packages.jsonFile:packages.jsonfile in thetest/TestPackagesdirectory, adhering to the newComponentDetectionManifestschema.Minor Code Improvements:
System.Text.Json.Serializationfor handling JSON serialization in the updated manifest structure.