-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft of incremental container generation #49556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
baronfel
wants to merge
17
commits into
dotnet:main
Choose a base branch
from
baronfel:incremental-containers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,152
−1,412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll existing usage of the content root
… OCI APIs - only reading from locally-available manifests
…ng manifest/layer/config to intermediate output paths for incrementality purposes
…<->config digest alignemtn preventing upload
…to the manifest json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wholesale rewrite of the way that we generate container images to support better MSBuild incrementality (as well as controlling/caching the location that the SDK stores the pulled base image layers/manifests/etc).
In general, today we re-do a lot of work for each individual image:
We do all of these things per-RID, every build.
With this PR we attempt to:
Right now, for single-RID containers we are very incremental! The main gaps are: