Fix a couple of dotnet-watch test failures #49558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a couple of dotnet-watch test failures by adding regex-based output assertions, improving update logging, and updating tests to use the new assertions for cross-platform path separators.
- Added
AssertOutputContains(Regex)inWatchableAppand implementedAssertEx.ContainsPattern. - Enhanced
UpdateSourceFileto distinguish between added and updated files in test logs. - Updated existing tests to use regex assertions to handle path separator variations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dotnet-watch.Tests/Watch/Utilities/WatchableApp.cs | Added AssertOutputContains(Regex) overload and imported Regex. |
| test/dotnet-watch.Tests/Watch/Utilities/DotNetWatchTestBase.cs | Improved UpdateSourceFile to log whether a file was added or updated. |
| test/dotnet-watch.Tests/Utilities/AssertEx.cs | Implemented ContainsPattern to assert regex matches in output. |
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Updated test to use AssertOutputContains(new Regex(...)) for path globs. |
Comments suppressed due to low confidence (2)
test/dotnet-watch.Tests/Watch/Utilities/DotNetWatchTestBase.cs:33
- [nitpick] The variable name 'existed' is ambiguous; consider renaming it to 'fileExisted' or 'didExist' for clearer intent.
var existed = File.Exists(path);
test/dotnet-watch.Tests/Utilities/AssertEx.cs:258
- The new
ContainsPatternassertion method isn't directly covered by its own unit tests. Add dedicated tests for both matching and non-matching scenarios to ensure it behaves as expected.
public static void ContainsPattern(Regex expected, IEnumerable<string> items)
|
@DustinCampbell ptal |
DustinCampbell
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating DefaultItemExcludes account for Unix directory separators (not sure why the test passed CI).
AddSourceFile tested adding and then updating source files. Apparently, the file system may reorder these operations and dotnet-watch might observe the update before the addition and try apply change, which will fail.