Add feature switch to control HTTP3 support #49564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a feature switch to control HTTP/3 support via SDK properties and tests.
- Introduces
Http3Supportproperty in the KitchenSink test project - Updates publish tests to include the new
System.Net.SocketsHttpHandler.Http3Supportsetting - Maps
Http3Supportto aRuntimeHostConfigurationOptioninMicrosoft.NET.Sdk.targets
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj | Added <Http3Support> property to the test project |
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs | Included Http3Support in the published settings test |
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets | Mapped Http3Support property to runtime config option |
Comments suppressed due to low confidence (2)
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs:83
- Consider adding a complementary test case where
Http3Supportis set totrueto verify that enabling HTTP/3 is correctly applied during publish.
""System.Net.SocketsHttpHandler.Http3Support"": false,
test/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj:33
- [nitpick] Adjust the indentation of the
<Http3Support>element to align with the surrounding properties (6 spaces) for consistency with the file’s style.
<Http3Support>false</Http3Support>
eerhardt
approved these changes
Jun 26, 2025
MichalStrehovsky
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref #117012 Ref dotnet/sdk#49564
MichalStrehovsky
added a commit
to MichalStrehovsky/xamarin-macios
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref dotnet/sdk#49564
MichalStrehovsky
added a commit
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref #49564
MichalStrehovsky
added a commit
to MichalStrehovsky/android
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref dotnet/sdk#49564
rolfbjarne
pushed a commit
to dotnet/macios
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref dotnet/sdk#49564
MichalStrehovsky
added a commit
that referenced
this pull request
Jun 27, 2025
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref #49564
jonathanpeppers
pushed a commit
to dotnet/android
that referenced
this pull request
Jun 27, 2025
Context: dotnet/runtime#117012 Context: dotnet/sdk#49564 Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements dotnet/runtime#117012.